From 6ca3127a0829cda80e0f9f003085dc4bb5fecdff Mon Sep 17 00:00:00 2001 From: Mike Goldsmth Date: Fri, 15 Mar 2024 12:57:59 +0000 Subject: [PATCH 1/2] maint: Update README with latest OTel SDK version and note for HTTP semantic convention --- .tool-versions | 1 + README.md | 8 +++++++- 2 files changed, 8 insertions(+), 1 deletion(-) create mode 100644 .tool-versions diff --git a/.tool-versions b/.tool-versions new file mode 100644 index 0000000..71f8ae2 --- /dev/null +++ b/.tool-versions @@ -0,0 +1 @@ +dotnet 6.0.300 diff --git a/README.md b/README.md index 1fd8bbb..4eb1601 100644 --- a/README.md +++ b/README.md @@ -10,7 +10,13 @@ It makes getting started with OpenTelemetry and Honeycomb easier! Latest release built with: -- [OpenTelemetry Version 1.4.0](https://github.com/open-telemetry/opentelemetry-dotnet/releases/tag/core-1.4.0) +- [OpenTelemetry Version 1.6.0](https://github.com/open-telemetry/opentelemetry-dotnet/releases/tag/core-1.6.0) + +***NOTE*** + +OpenTelemetry .NET SDK versions after 1.6.0 use updated HTTP semantic conventions that result in different telemetry attribute keys and can contribute to unexpected query results in Honeycomb. For this reason, we have decided the Honeycomb OpenTelemetry distro will not take further updates yet. + +Please see our [Migration guide for HTTP semantic conventions](https://docs.honeycomb.io/troubleshoot/product-lifecycle/recommended-migrations/#migrate-to-stabilized-opentelemetry-semantic-conventions) for more details. ## Getting Started From 13e39261e46eac189f9536bbb11128f081335d49 Mon Sep 17 00:00:00 2001 From: Mike Goldsmth Date: Fri, 15 Mar 2024 13:22:01 +0000 Subject: [PATCH 2/2] remove .tool-versions from source control --- .gitignore | 5 ++++- .tool-versions | 1 - 2 files changed, 4 insertions(+), 2 deletions(-) delete mode 100644 .tool-versions diff --git a/.gitignore b/.gitignore index 26c17f6..817e8d0 100644 --- a/.gitignore +++ b/.gitignore @@ -457,4 +457,7 @@ $RECYCLE.BIN/ smoke-tests/collector/data.json smoke-tests/collector/data-results/*.json smoke-tests/report.xml -smoke-tests/report.html \ No newline at end of file +smoke-tests/report.html + +# asdf local tools versions file +.tool-versions \ No newline at end of file diff --git a/.tool-versions b/.tool-versions deleted file mode 100644 index 71f8ae2..0000000 --- a/.tool-versions +++ /dev/null @@ -1 +0,0 @@ -dotnet 6.0.300