Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add trace key length as metric #1365

Open
MikeGoldsmith opened this issue Oct 7, 2024 · 0 comments
Open

Add trace key length as metric #1365

MikeGoldsmith opened this issue Oct 7, 2024 · 0 comments

Comments

@MikeGoldsmith
Copy link
Contributor

MikeGoldsmith commented Oct 7, 2024

The trace key builder was updated to have a maximum number of unique values. This issue tracks exposing the number of values used to build a trace key as a metric, likely a histogram.


          OK; the function here doesn't have access to a logger, so I had it return the key size it's using and log if it is the max value.

It occurs to me that we could now make a metric out of this, but I don't have time to do that. Please feel free if you think that's a good idea.

Originally posted by @kentquirk in #1364 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant