Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Baby ducks only #3

Open
hairmare opened this issue Oct 27, 2020 · 5 comments · May be fixed by #4
Open

Baby ducks only #3

hairmare opened this issue Oct 27, 2020 · 5 comments · May be fixed by #4

Comments

@hairmare
Copy link

What would you like to be added:
Support requesting baby ducks only!

Why is this needed:
because baby ducks....



I'm not sure about the onomatopoeia though.
@jeefy
Copy link
Member

jeefy commented Oct 27, 2020

Do we already have a /quack?

@hairmare
Copy link
Author

yepp... https://twitter.com/hairmare/status/1321224133569556482

honk-twitter-bot/main.go

Line 26 in 20dfc3b

commandQuackMatch = regexp.MustCompile(`(?mi)^*/(?:quack)(?: +(.+?))?\s*$`)

@jeefy
Copy link
Member

jeefy commented Oct 27, 2020 via email

@hairmare
Copy link
Author

I think I'm on team, let's change it to babies only for /quack, because 😍

@hairmare
Copy link
Author

"baby duck" works in unsplash but i don't want to force a BREAKING CHANGE on y'all, would you consider changing the query for /quack to that if I decide to do a PR?

hairmare added a commit to hairmare/honk-twitter-bot that referenced this issue Oct 27, 2020
@hairmare
fix(quack): all abies because they cute
3707da6 
Fixes honk-ci#3
hairmare added a commit to hairmare/honk-twitter-bot that referenced this issue Oct 27, 2020
@hairmare
fix(quack): only babies because they cute
698a2f6 
Fixes honk-ci#3
@hairmare hairmare linked a pull request Oct 27, 2020 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(quack): only babies because they cute hairmare/honk-twitter-bot
2 participants
@hairmare @jeefy