Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deno run -A npm:create-hono@latest doesn't exit the program #3528

Closed
akshaybabloo opened this issue Oct 18, 2024 · 5 comments
Closed

deno run -A npm:create-hono@latest doesn't exit the program #3528

akshaybabloo opened this issue Oct 18, 2024 · 5 comments
Labels

Comments

@akshaybabloo
Copy link

What version of Hono are you using?

4.6.5

What runtime/platform is your app running on?

Deno 2.0.2

What steps can reproduce the bug?

After running deno run -A npm:create-hono@latest the program never exits. Here is the output

$ deno run -A npm:create-hono@latest
create-hono version 0.14.1
? Target directory my-app
? Which template do you want to use? deno
✔ Cloning the template

The application is stuck at Cloning the template

What is the expected behavior?

No response

What do you see instead?

No response

Additional information

A bug report has been submitted at Deno - denoland/deno#26403

@yusukebe
Copy link
Member

@akshaybabloo Thank you for the PR!

Hi @blazeshomida

I think this is the same problem you want to solve with honojs/create-hono#76. Perhaps we have to merge it to resolve this problem, though I've closed it. What do you think of it?

@blazeshomida
Copy link

@yusukebe It's the same issue, although I think the issue is on the Deno side because the script only hangs with the deno command. It also does the same when using the deno command to create a Vite project. Although not sure if it's because you need to explicitly exit the script with Deno. If so, the change I proposed should fix it. Basically just adding the exit call to the emitter completed callback.

@akshaybabloo
Copy link
Author

I didn't know that this issue already existed. I can comment it on Deno's side.

Would you like to keep this open as an upstream issue or close it?

@yusukebe
Copy link
Member

yusukebe commented Oct 20, 2024

@akshaybabloo

cc: @blazeshomida

This may be caused by a Deno-side bug or by it not being implemented on the Deno side. But with this PR honojs/create-hono#76 by @blazeshomida, it will work fine. I've closed it, but now I've reopened it and will merge it. You can use the new version soon and close this issue. I think you can leave denoland/deno#26403 open.

@yusukebe
Copy link
Member

This issue was fixed by honojs/create-hono#76!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants