Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Let the labeling proc block accept a single word list string #310

Open
Michael-F-Bryan opened this issue Sep 18, 2021 · 0 comments
Open

Let the labeling proc block accept a single word list string #310

Michael-F-Bryan opened this issue Sep 18, 2021 · 0 comments
Labels
area - proc blocks Procedural blocks linked to by the compiled Rune category - intuitiveness Something which may be unintuitive to the user or affect ergonomics category - performance Something that impacts runtime performance. effort - easy This should be pretty simple good first issue Good for newcomers

Comments

@Michael-F-Bryan
Copy link
Contributor

One of the hackers on Discord caused the Rust compiler to OOM because they pasted 99,000 labels into their Runefile.

Ideally people would use resources for something like this, but the labeling proc block only accepts Vec<&'a str> (i.e. a list of strings). We should give it a set_word_list() method which takes one long string and does self.labels = word_list.lines().collect().
@Michael-F-Bryan Michael-F-Bryan added category - intuitiveness Something which may be unintuitive to the user or affect ergonomics category - performance Something that impacts runtime performance. area - proc blocks Procedural blocks linked to by the compiled Rune labels Sep 18, 2021
This was referenced Sep 20, 2021
Closed
Open
@Michael-F-Bryan Michael-F-Bryan added effort - easy This should be pretty simple good first issue Good for newcomers labels Sep 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area - proc blocks Procedural blocks linked to by the compiled Rune category - intuitiveness Something which may be unintuitive to the user or affect ergonomics category - performance Something that impacts runtime performance. effort - easy This should be pretty simple good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Michael-F-Bryan