Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the compiler's internals deterministic #348

Open
Michael-F-Bryan opened this issue Oct 7, 2021 · 0 comments
Open

Make the compiler's internals deterministic #348

Michael-F-Bryan opened this issue Oct 7, 2021 · 0 comments
Labels
area - runefile The parsing and analysis of Runefiles category - bug Something isn't working effort - hard This should be pretty simple to fix

Comments

@Michael-F-Bryan
Copy link
Contributor

While implementing #345 we added a fairly benign test to make sure the right error message is emitted when making sure our pipeline is a DAG and has no loops.

Error Cycle detected when checking "another_model"
1 │ version: 1
  │ ^
  │
  = ... which passes data to "some_model"...
  = ... which passes data to "another_model", completing the cycle.

However, about half the instead of saying there is a cycle between another_model -> some_model -> another_model, it'll say the cycle is some_model -> another_model -> some_model, which makes the test fail spuriously.

I'm guessing this is because queries aren't guaranteed to yield entities in the same order every time, because even when we switch all HashMaps to IndexMaps the test will spuriously fail.

@Michael-F-Bryan Michael-F-Bryan added category - bug Something isn't working effort - hard This should be pretty simple to fix area - runefile The parsing and analysis of Runefiles labels Oct 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area - runefile The parsing and analysis of Runefiles category - bug Something isn't working effort - hard This should be pretty simple to fix
Projects
None yet
Development

No branches or pull requests

1 participant