Frontend implementation of additional feature selection during project creation #1806
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…feature-selection
github-actions
bot
added
enhancement
spwoodcock
added
priority:low
spwoodcock
reviewed
Sep 24, 2024
| @@ -80,7 +80,7 @@ const SelectForm = ({ flag, geojsonFile, customFormFile, setCustomFormFile }) => | |||
| }; | |||
| useEffect(() => { | |||
| if (customFormFile && !customFileValidity) { | |||
| dispatch(ValidateCustomForm(`${import.meta.env.VITE_API_URL}/projects/validate-form`, customFormFile)); | |||
| dispatch(ValidateCustomForm(`${import.meta.env.VITE_API_URL}/projects/validate-form?debug=true`, customFormFile)); | |||
There was a problem hiding this comment.
Minor change: this shouldn't use debug=true as it doesn't do any actual validation then (it's to return and inspect the form if there are errors).
I will merge anyway then update on the branch 👍
spwoodcock
approved these changes
Sep 24, 2024
|
This was fast! Might as well get it in the release as it doesn't affect any existing functionality 😄 |
spwoodcock
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Related Issue
Describe this PR
This PR contains works on additional feature upload on
Map Featuresstep.Screenshots