Fix project details map #917
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e(only map visible)
…information for small screen
…tion splitted to projectOption component. projectOptions added for others bottomSheet
…nverted dom manipulation to react states
…-project-details-map
for more information, see https://pre-commit.ci
…emoved, mapLegend removed from projectOptions
…or small screen view
…3/fmtm into fix-project-details-map
varun2948
reviewed
Oct 17, 2023
| <p className="fmtm-text-2xl">Map Legend</p> | ||
| </div> | ||
| <div className="fmtm-flex fmtm-flex-col fmtm-gap-4"> | ||
| {MapDetails.map((data, index) => { |
There was a problem hiding this comment.
@NSUWAL123 Can you make a seperate component for this legend ? As right now its packed with too much html elements and rendering multiple elements.
varun2948
requested changes
Oct 17, 2023
varun2948
approved these changes
Oct 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains UI adjustments made to solve problems encountered on mobile browser of 'Project Details' page due to mobile browser top bar on bottom sheet & footer. And seperating map legend from others tab.