Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature/New UI for create project #918

Merged
merged 87 commits into from
Oct 17, 2023

Conversation

varun2948
Copy link
Collaborator

  1. All Steps have been revised with changes in most of the functioning of the Create project Pages
    here's a preview of the step
    image

You can check all the steps on the create project and tweak around a bit
Probable bugs could be there with this PR letting @spwoodcock know that we will now gradually keep improving this feature with the requirement and bug fixes here and there. Sorry for this huge PR

NSUWAL123 and others added 30 commits September 26, 2023 09:51
* fix (create new project): create new project url updated

* fix (create new project): upload area - select a file issue solved

* fix (create new project): data extract - select a file issue solved

* fix (radiobutton): option selection on label click, UI fix

* fix (create new project): initial values for project details form added

* feat (select): custom select component added

* fix (create new project): data extract - shadcn select replaced with customselect

* fix (custom select): updated props

* fix (create new project): project detials - shadcn select replaced with customselect

* fix (select): shadcn components export removed

* fix (create new project): select form - shadcn select replaced with customselect

* fix radiobutton):  - value prop added

* fix (create new project): upload area - value prop added to radiobutton, map added

* fix (create new project): event cleanup added
@varun2948 varun2948 temporarily deployed to test October 17, 2023 11:14 — with GitHub Actions Inactive
@github-actions github-actions bot added the frontend Related to frontend code label Oct 17, 2023
@pre-commit-ci pre-commit-ci bot temporarily deployed to test October 17, 2023 11:15 Inactive
@varun2948 varun2948 temporarily deployed to test October 17, 2023 13:56 — with GitHub Actions Inactive
@varun2948 varun2948 self-assigned this Oct 17, 2023
@varun2948 varun2948 added the enhancement New feature or request label Oct 17, 2023
@spwoodcock
Copy link
Member

Just checking - so I shouldn't merge this if I understand correctly?
@varun2948 and @NSUWAL123 will keep pushing updates here.

@varun2948
Copy link
Collaborator Author

@spwoodcock No, you can merge it now. I completed most of the functionality so little tweaks will happe on other PR, after this looks good on development server

@varun2948
Copy link
Collaborator Author

@spwoodcock as i noticed now frontend test case have failed something to do with my package install or anything you know ?

@spwoodcock spwoodcock temporarily deployed to test October 17, 2023 15:32 — with GitHub Actions Inactive
@spwoodcock
Copy link
Member

Fixed 👍
The pnpm-lock.yaml just needs to be rebuilt and pushed after adding a package.
pnpm install will do it.

@spwoodcock spwoodcock merged commit 1ae34f6 into development Oct 17, 2023
6 of 7 checks passed
@spwoodcock spwoodcock deleted the feat-createproject-projectdetails-new branch October 17, 2023 15:35
@varun2948
Copy link
Collaborator Author

@spwoodcock I am having an issue installing the package from my own local file system like going into fmtm and src/frontend and pnpm install is that not how we should do it? do i need to go to docker exec -it fmtm bash and do pnpm install ?

@spwoodcock
Copy link
Member

Yes you should be able to

cd src/frontend
pnpm install

Are you getting an error?

You shouldn't have to install via docker.
That is done during the docker build of the frontend.
To rebuild the frontend image for running:
docker compose build ui

@varun2948
Copy link
Collaborator Author

@spwoodcock Yeah not only me most of us were getting errors related to any package installed on the frontend side but when we do a --no-build-cache build and docker compose down and docker compose up it goes away will create an issue based on this if again something like this comes up and put a real detail on the issue.

@spwoodcock
Copy link
Member

Ah yes, I see the issue - in the docker-compose.yml:

    volumes:
      - ./src/frontend:/app
      - /app/node_modules/

The second volume prevents the local node_modules being mounted into the container.
This is nice, as we don't always have to pnpm install locally and docker build too.

The issue is that it prevents the node_modules updating when just running docker compose up.
We also have to run docker compose down first.

I think this could be handled better - thanks for raising 👍 (I'll look into it)

@varun2948
Copy link
Collaborator Author

ah thats why it always acted weird installing new packages it didn't use local node_modules so had to do inside the docker container.

@spwoodcock
Copy link
Member

spwoodcock commented Oct 18, 2023

One extra thing.

Copying the pnpm-lock.yml seems to be have been missed in the frontend dockerfiles after the pnpm upgrade.

So adding these may help (I will push now).

The solution for the above (renewing node_modules after adding a dependency / rebuilding), is to use the flag: docker compose up -d --renew-anon-volumes, which will recrease the node_modules dir for you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request frontend Related to frontend code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants