Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle all_geometry key in JSON config #15

Open
spwoodcock opened this issue Feb 14, 2024 · 0 comments
Open

Handle all_geometry key in JSON config #15

spwoodcock opened this issue Feb 14, 2024 · 0 comments
Labels
bug Something isn't working help wanted Extra attention is needed

Comments

@spwoodcock
Copy link
Member

spwoodcock commented Feb 14, 2024 •
edited
Loading

Describe the bug

The JSON config from raw-data-api supports all_geometry, avoiding having to specify each geometry type individually.

To Reproduce

  • Parsing of this key fails.
  • Enable the commented out test to see the issue.

Expected behavior

  • The all_geometry key should be both parsed correctly by QueryConfig.parseJson and exported correctly by PostgresClient.createJson.
  • The resulting JSON config should be able to be fed back around in a loop - they configs are the same.

Additional context

  • There are some FIXME tags in the code specifying where this need to be done.
@spwoodcock spwoodcock added bug Something isn't working help wanted Extra attention is needed labels Feb 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@spwoodcock