Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Several users with invalid usernames #766

Open
colindean opened this issue Jul 12, 2013 · 3 comments
Open

Several users with invalid usernames #766

colindean opened this issue Jul 12, 2013 · 3 comments
Labels

Comments

@colindean
Copy link
Contributor

Linked via https://rstat.us/users:

Side note: All are presumably spam accounts.

@wilkie
Copy link
Contributor

wilkie commented Jul 12, 2013

These robots are smart. How did they do that. The error comes from the server, so it's not like you can craft a POST in some obvious way.

This User model validation should not allow this to happen:
https://github.com/hotsh/rstat.us/blob/master/app/models/user.rb#L422-L426

How about some optimism. They may left over from when these types of accounts slipped through. It may be time to just delete them or truncate their names to remove the domains.

@colindean
Copy link
Contributor Author

🔨 delete!

@wilkie
Copy link
Contributor

wilkie commented Jul 12, 2013

Yeah, it is just a bunch of Author classes marked as local with no User. Those can safely be deleted and I have done so.

This is the cause... it shouldn't create an Author if the User model can't be saved:
https://github.com/hotsh/rstat.us/blob/master/app/controllers/users_controller.rb#L93

Who wants to fix it? :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants