Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix loader not dismissing in case of login failure #259

Open
2 tasks
amansinghbais opened this issue Feb 8, 2024 · 0 comments · May be fixed by #260
Open
2 tasks

Fix loader not dismissing in case of login failure #259

amansinghbais opened this issue Feb 8, 2024 · 0 comments · May be fixed by #260

Comments

@amansinghbais
Copy link
Contributor

Current behavior

Loader not getting dismissed in case of login failure when any api throws an error.

Expected behavior

Loader should be dismissed after the execution of api whether it fails or success.

Steps to reproduce the issue

Can you handle fixing this bug by yourself?

  • YES
  • NO

Environment details

  • Browser:
  • OS:
  • Code Version:

Additional information
@amansinghbais amansinghbais self-assigned this Feb 8, 2024
@Ritika-Patel08 Ritika-Patel08 linked a pull request Feb 8, 2024 that will close this issue
Open
1 task
@dt2patel dt2patel reopened this Jul 15, 2024
@dt2patel dt2patel assigned ravilodhi and unassigned Ritika-Patel08 Jul 15, 2024
@ravilodhi ravilodhi removed their assignment Jul 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
Digital Experience Platform
Status: 👀 In review
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixed: loader which was not getting dismissed when API failed Ritika-Patel08/dxp-components
4 participants
@ravilodhi @dt2patel @amansinghbais @Ritika-Patel08