From 79edb40564b43ef22ae0a7fdcbb9a78dea9e72a6 Mon Sep 17 00:00:00 2001 From: Yash Maheshwari Date: Wed, 12 Jul 2023 16:19:44 +0530 Subject: [PATCH 1/3] Implemented: support to display the picker id below picker name in the assign picker modal on open page(#183) --- src/views/AssignPickerModal.vue | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/views/AssignPickerModal.vue b/src/views/AssignPickerModal.vue index e59c0e60..3e5675fb 100644 --- a/src/views/AssignPickerModal.vue +++ b/src/views/AssignPickerModal.vue @@ -27,7 +27,10 @@
{{ 'No picker found' }}
- {{ picker.name }} + + {{ picker.name }} +

{{ picker.id }}

+
From 2cdfdd91305d91ef84905243aa30f9a40f034505 Mon Sep 17 00:00:00 2001 From: Aditya Sharma Date: Wed, 12 Jul 2023 16:30:33 +0530 Subject: [PATCH 2/3] Improved: used externalId instead of partyId --- src/views/AssignPickerModal.vue | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/src/views/AssignPickerModal.vue b/src/views/AssignPickerModal.vue index 3e5675fb..c7e68268 100644 --- a/src/views/AssignPickerModal.vue +++ b/src/views/AssignPickerModal.vue @@ -29,7 +29,7 @@ {{ picker.name }} -

{{ picker.id }}

+

{{ picker.externalId }}

@@ -196,7 +196,7 @@ export default defineComponent({ orderBy: "firstName ASC", filterByDate: "Y", distinct: "Y", - fieldList: ["firstName", "lastName", "partyId"] + fieldList: ["firstName", "lastName", "partyId", "externalId"] } try { @@ -204,7 +204,8 @@ export default defineComponent({ if (resp.status === 200 && !hasError(resp)) { this.pickers = resp.data.docs.map((picker) => ({ name: picker.firstName+ ' ' +picker.lastName, - id: picker.partyId + id: picker.partyId, + externalId: picker.externalId })) } else { throw resp.data @@ -238,4 +239,4 @@ ion-row { ion-chip { flex-shrink: 0; } - \ No newline at end of file + From 3f1440e7094b7b214a26abf1d756a71a90934bc5 Mon Sep 17 00:00:00 2001 From: Aditya Sharma Date: Wed, 12 Jul 2023 16:31:41 +0530 Subject: [PATCH 3/3] Improved: added fallback for the party externalId --- src/views/AssignPickerModal.vue | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/views/AssignPickerModal.vue b/src/views/AssignPickerModal.vue index c7e68268..f4494f69 100644 --- a/src/views/AssignPickerModal.vue +++ b/src/views/AssignPickerModal.vue @@ -29,7 +29,7 @@ {{ picker.name }} -

{{ picker.externalId }}

+

{{ picker.externalId ? picker.externalId : picker.id }}