From d282c271eaf24c5a07ee4d88d5a9c563bfbe4df0 Mon Sep 17 00:00:00 2001
From: amansinghbais <singh11amanbais@gmail.com>
Date: Tue, 20 Feb 2024 18:23:19 +0530
Subject: [PATCH 1/4] Improved: added spinner in launchpad login next button to
 be shown while checkLoginOption request accomplishes (#88)

---
 src/views/Login.vue | 11 +++++++++--
 1 file changed, 9 insertions(+), 2 deletions(-)

diff --git a/src/views/Login.vue b/src/views/Login.vue
index 631448b..cb1519e 100644
--- a/src/views/Login.vue
+++ b/src/views/Login.vue
@@ -11,9 +11,12 @@
             </ion-item>
 
             <div class="ion-padding">
+              <ion-button v-if="isSpinnerActive" color="primary" expand="block">
+                <ion-spinner />
+              </ion-button>
               <!-- @keyup.enter.stop to stop the form from submitting on enter press as keyup.enter is already bound
               through the form above, causing both the form and the button to submit. -->
-              <ion-button color="primary" expand="block" @click.prevent="setOms()" @keyup.enter.stop>
+              <ion-button v-else color="primary" expand="block" @click.prevent="setOms()" @keyup.enter.stop>
                 {{ $t("Next") }}
                 <ion-icon slot="end" :icon="arrowForwardOutline" />
               </ion-button>
@@ -108,7 +111,8 @@ export default defineComponent({
       hideBackground: true,
       isConfirmingForActiveSession: false,
       loader: null as any,
-      loginOption: {} as any
+      loginOption: {} as any,
+      isSpinnerActive: false
     };
   },
   ionViewWillEnter() {
@@ -203,6 +207,8 @@ export default defineComponent({
         return
       }
 
+      this.isSpinnerActive = true
+
       const instanceURL = this.instanceUrl.trim().toLowerCase();
       if (!this.baseURL) this.authStore.setOMS(this.alias[instanceURL] ? this.alias[instanceURL] : instanceURL);
 
@@ -217,6 +223,7 @@ export default defineComponent({
       } else {
         this.toggleOmsInput()
       }
+      this.isSpinnerActive = false
     },
     async fetchLoginOptions() {
       this.loginOption = {}

From 5417216d308a9816cad240d32216dd5aad1232eb Mon Sep 17 00:00:00 2001
From: amansinghbais <singh11amanbais@gmail.com>
Date: Tue, 20 Feb 2024 18:26:33 +0530
Subject: [PATCH 2/4] Improved: added  import for the IonSpinner in Login page
 (#88)

---
 src/views/Login.vue | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/src/views/Login.vue b/src/views/Login.vue
index cb1519e..e2c3c68 100644
--- a/src/views/Login.vue
+++ b/src/views/Login.vue
@@ -72,6 +72,7 @@ import {
   IonItem,
   IonLabel,
   IonPage,
+  IonSpinner,
   loadingController
 } from "@ionic/vue";
 import { defineComponent } from "vue";
@@ -97,6 +98,7 @@ export default defineComponent({
     IonItem,
     IonLabel,
     IonPage,
+    IonSpinner,
     Logo
   },
   data () {

From bd54b834b6a1f3f250c5242f1b317328fe7a190c Mon Sep 17 00:00:00 2001
From: amansinghbais <singh11amanbais@gmail.com>
Date: Wed, 20 Mar 2024 12:20:52 +0530
Subject: [PATCH 3/4] Improved: variable name for checking whether api is
 loading or not (#88)

---
 src/views/Login.vue | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/views/Login.vue b/src/views/Login.vue
index e2c3c68..5b61640 100644
--- a/src/views/Login.vue
+++ b/src/views/Login.vue
@@ -11,7 +11,7 @@
             </ion-item>
 
             <div class="ion-padding">
-              <ion-button v-if="isSpinnerActive" color="primary" expand="block">
+              <ion-button v-if="isLoading" color="primary" expand="block">
                 <ion-spinner />
               </ion-button>
               <!-- @keyup.enter.stop to stop the form from submitting on enter press as keyup.enter is already bound
@@ -114,7 +114,7 @@ export default defineComponent({
       isConfirmingForActiveSession: false,
       loader: null as any,
       loginOption: {} as any,
-      isSpinnerActive: false
+      isLoading: false
     };
   },
   ionViewWillEnter() {
@@ -209,7 +209,7 @@ export default defineComponent({
         return
       }
 
-      this.isSpinnerActive = true
+      this.isLoading = true
 
       const instanceURL = this.instanceUrl.trim().toLowerCase();
       if (!this.baseURL) this.authStore.setOMS(this.alias[instanceURL] ? this.alias[instanceURL] : instanceURL);
@@ -225,7 +225,7 @@ export default defineComponent({
       } else {
         this.toggleOmsInput()
       }
-      this.isSpinnerActive = false
+      this.isLoading = false
     },
     async fetchLoginOptions() {
       this.loginOption = {}

From b56f8cd22c4981e9a49e4349a7b931eb1c7374c5 Mon Sep 17 00:00:00 2001
From: amansinghbais <singh11amanbais@gmail.com>
Date: Fri, 23 Aug 2024 10:52:33 +0530
Subject: [PATCH 4/4] Improved: code to stop click event over next button until
 api call in progress (#88)

---
 src/views/Login.vue | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/views/Login.vue b/src/views/Login.vue
index 3b19860..4bfb353 100644
--- a/src/views/Login.vue
+++ b/src/views/Login.vue
@@ -12,7 +12,7 @@
             <div class="ion-padding">
               <!-- @keyup.enter.stop to stop the form from submitting on enter press as keyup.enter is already bound
               through the form above, causing both the form and the button to submit. -->
-              <ion-button color="primary" expand="block" @click.prevent="setOms()" @keyup.enter.stop>
+              <ion-button color="primary" expand="block" @click.prevent="isCheckingOms ? '' : setOms()" @keyup.enter.stop>
                 {{ $t("Next") }}
                 <ion-spinner v-if="isCheckingOms" name="crescent" data-spinner-size="medium" slot="end" />
                 <ion-icon v-else slot="end" :icon="arrowForwardOutline" />