Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed: scanning failure issue caused by empty quantity values when scanning barcode #308 #310

Merged
merged 6 commits into from
Feb 21, 2024

Conversation

Ritika-Patel08
Copy link
Contributor

Related Issues

Closes #308

Short Description and Why It's Useful

Resolved scanning failure caused by empty quantity fields by implementing automatic quantity update when scanning barcodes added toast message display for unavailable products to enhance user feedback.

Screenshots of Visual Changes before/after (If There Are Any)

IMPORTANT NOTICE - Remember to add changelog entry

Contribution and Currently Important Rules Acceptance

@Ritika-Patel08 Ritika-Patel08 changed the title Fixed scanning failure issue caused by empty quantity values (removing 0) when scanning barcode and added toast message when product not found #308 Fixed: scanning failure issue caused by empty quantity values (removing 0) when scanning barcode and added toast message when product not found #308 Feb 13, 2024
@Ritika-Patel08 Ritika-Patel08 changed the title Fixed: scanning failure issue caused by empty quantity values (removing 0) when scanning barcode and added toast message when product not found #308 Fixed: scanning failure issue caused by empty quantity values when scanning barcode #308 Feb 13, 2024
Copy link
Contributor

@ymaheshwari1 ymaheshwari1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check if we need to handle this case for other pages.

src/store/modules/shipment/actions.ts Outdated Show resolved Hide resolved
src/store/modules/shipment/actions.ts Outdated Show resolved Hide resolved
src/store/modules/shipment/actions.ts Show resolved Hide resolved
…uct as an integer, avoiding concatenation errors
src/store/modules/order/actions.ts Outdated Show resolved Hide resolved
src/store/modules/shipment/actions.ts Outdated Show resolved Hide resolved
…Int in false condition and added space inside find()
@ymaheshwari1 ymaheshwari1 merged commit 7fe09e3 into hotwax:main Feb 21, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

When scanning a barcode with empty qty value(remove 0) scanning fails
3 participants