From 4735ff97c672f9ce60274b2a6bc532f77e43b074 Mon Sep 17 00:00:00 2001 From: Gavin Halliday Date: Wed, 30 Oct 2024 10:23:51 +0000 Subject: [PATCH] HPCC-32907 Improve roxie startup time by removing unused option * The helper name has been computed for many years, but roxie still contained code to extract it from the graph if it was set. Signed-off-by: Gavin Halliday --- roxie/ccd/ccdquery.cpp | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/roxie/ccd/ccdquery.cpp b/roxie/ccd/ccdquery.cpp index 29c34c9fa2d..c983ebd0067 100644 --- a/roxie/ccd/ccdquery.cpp +++ b/roxie/ccd/ccdquery.cpp @@ -625,9 +625,7 @@ class CQueryFactory : implements IQueryFactory, implements IResourceContext, pub break; } StringBuffer helperName; - node.getProp("att[@name=\"helper\"]/@value", helperName); - if (!helperName.length()) - helperName.append("fAc").append(id); + helperName.append("fAc").append(id); HelperFactory *helperFactory = dll->getFactory(helperName); if (!helperFactory) throw MakeStringException(ROXIE_INTERNAL_ERROR, "Internal error: helper function %s not exported", helperName.str()); @@ -2002,9 +2000,7 @@ class CAgentQueryFactory : public CQueryFactory else { StringBuffer helperName; - node.getProp("att[@name=\"helper\"]/@value", helperName); - if (!helperName.length()) - helperName.append("fAc").append(node.getPropInt("@id", 0)); + helperName.append("fAc").append(node.getPropInt("@id", 0)); HelperFactory *helperFactory = dll->getFactory(helperName.str()); if (!helperFactory) throw MakeStringException(ROXIE_INTERNAL_ERROR, "Internal error: helper function %s not exported", helperName.str());