Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mahjong Artifacts missing part of the game play area #15828

Open
5 tasks done
benderscruffy opened this issue Aug 10, 2022 · 21 comments
Open
5 tasks done

Mahjong Artifacts missing part of the game play area #15828

benderscruffy opened this issue Aug 10, 2022 · 21 comments
Labels
Depth / Z Issue involves depth drawing parameters. GE emulation Backend-independent GPU issues
Milestone

Comments

@benderscruffy
Copy link

Game or games this happens in

Mahjong Artifacts NPUZ00062

What area of the game / PPSSPP

missing part of the game play area
PPSSPP v1 13 1-249-gf80dd088b - NPUZ00062 _ Mahjongg Artifacts 10_08_2022 9_57_12 PM

here is a GE Dump
NPUZ00062.zip

What should happen

this is what it is supposed to look like
0-256-03

Logs

No response

Platform

Windows

Mobile phone model or graphics card

AMD RX 580

PPSSPP version affected

PPSSPP v1.13.1-249

Last working version

No response

Graphics backend (3D API)

Vulkan

Checklist

  • Test in the latest git build in case it's already fixed.
  • Search for other reports of the same issue.
  • Try resetting settings or older versions and include if the issue is related.
  • Try without any cheats and without loading any save states.
  • Include logs or screenshots of issue.
@hrydgard hrydgard added the GE emulation Backend-independent GPU issues label Aug 10, 2022
@hrydgard hrydgard added this to the v1.14.0 milestone Aug 10, 2022
@unknownbrackets unknownbrackets added the Depth / Z Issue involves depth drawing parameters. label Aug 11, 2022
@unknownbrackets
Copy link
Collaborator

I'm pretty sure this is depth related - the dump unfortunately doesn't include the board, which must've been rendered in a previous frame. A frame dump while using the software renderer would be helpful.

That said, the minz and maxz are both set to exactly 0, and I think some accuracy issue is causing the top left (which does use zero depth values) not render.

-[Unknown]

@sum2012
Copy link
Collaborator

sum2012 commented Aug 17, 2022

Last bad v1.13.1-289-ga35d26190
First good v1.13.1-291-g8d0c84bf0
That mean #15845
It is simple workaround for fix for another game.
Not sure can close

@hrydgard
Copy link
Owner

That should be fixed once #15858 is in, since the feature that #15845 fixes goes away and is replaced with a different method to achieve the same thing.

@unknownbrackets
Copy link
Collaborator

Is this still working now in the latest git?

-[Unknown]

@sum2012
Copy link
Collaborator

sum2012 commented Aug 20, 2022

v1.13.1-381-g5046cbd01 still working

@unknownbrackets
Copy link
Collaborator

Thanks for confirming - I'll close this then.

-[Unknown]

@sum2012
Copy link
Collaborator

sum2012 commented Aug 21, 2022

2 nd try no problem

@hrydgard
Copy link
Owner

Thanks, will look into it.

@sum2012
Copy link
Collaborator

sum2012 commented Aug 21, 2022

@benderscruffy Can you try v1.13.1-381-g5046cbd01 ?

@sum2012
Copy link
Collaborator

sum2012 commented Aug 21, 2022

@benderscruffy How about v1.13.1-291-g8d0c84bf0 ?

@unknownbrackets
Copy link
Collaborator

Strangely, even the software renderer frame dumps have black sections (the texture is black.) I suspect this game renders the board either on CPU or to a temporary buffer, and then just textures from that. Somehow, some parts of that are coming out black.

It could be a misdetected framebuffer suboffset. That said, I don't see why software would have black textures...

-[Unknown]

@hrydgard hrydgard modified the milestones: v1.14.0, Future-Prio Nov 7, 2022
@hrydgard
Copy link
Owner

Hm, got a similar report through e-mail that looks a little bit different:

mahjong artifacts chapter 2 issues
mahjong artifacts chapter 1 issue

@hrydgard
Copy link
Owner

Like the others, this is not likely to be specific to your old pc, so I'm reopening.

@hrydgard hrydgard reopened this Nov 30, 2023
@sum2012
Copy link
Collaborator

sum2012 commented Dec 1, 2023

v1.16.6-372-gc3f881b7a
I am using integrated AMD gpu of cpu (AMD Ryzen 7900)
1

@hrydgard
Copy link
Owner

hrydgard commented Oct 15, 2024

@sum2012 could you try this again on AMD? I suspect a recent fix might have taken care of that.

@sum2012
Copy link
Collaborator

sum2012 commented Oct 16, 2024

v1.17.1-1268 not solved
edit: Nvidia GT 710 also same issuee

@sum2012
Copy link
Collaborator

sum2012 commented Oct 16, 2024

soft gpu get assort
5

@hrydgard
Copy link
Owner

Hm, ok, different problem then. Also, thanks for reporting the softgpu one, I'll fix it shortly!

@hrydgard
Copy link
Owner

two more things, sorry @sum2012 :

Could you get a GE frame dump? I can't find one in the previous posts.

Also, I can't figure out how that can happen, looking at the code :/

What GPU do you have? Do you enable frameskipping or something?

@hrydgard
Copy link
Owner

Never mind, I think I figured out the assert. #19532

The rendering bug in this game is still a mystery though, will at least need a framedump. But fortunately playing with the software renderer should be fine in a game like this.

@sum2012
Copy link
Collaborator

sum2012 commented Oct 16, 2024

v1.17.1-1275 the softgpu is fixed.
framedump is in the first post
4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Depth / Z Issue involves depth drawing parameters. GE emulation Backend-independent GPU issues
Projects
None yet
Development

No branches or pull requests

4 participants