Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XML improvements #1

Open
rossabaker opened this issue Dec 26, 2014 · 10 comments
Open

XML improvements #1

rossabaker opened this issue Dec 26, 2014 · 10 comments
Labels
enhancement New feature or request module:scala-xml

Comments

@rossabaker
Copy link
Member

  • Split scala-xml dependency from core. It's no longer stdlib in Scala 2.11, and it won't be transitively inherited in Scalaz 7.2.
  • Decode to XMLEvents for streaming parsing.
  • Consider aalto-xml for incremental parsing. It looks like a great fit for scalaz-stream
@rossabaker rossabaker added the enhancement New feature or request label Dec 26, 2014
@rossabaker rossabaker self-assigned this Dec 26, 2014
@rossabaker
Copy link
Member Author

The overload of xml is nice from a DSL perspective, but shady. Namely, it will quietly ignore the implicit SAX parser.

@rossabaker
Copy link
Member Author

Started in 0.6. Let's finish it in 0.7.

@ChristopherDavenport
Copy link
Member

So this was on milestones for a very long time but hasn't been referenced in over a year, we should probably invest or close until there is renewed interest.

@rossabaker
Copy link
Member Author

I guess the question is whether the streaming support could be added later without breaking compatibility. I think the answer is yes?

@jmcardon
Copy link
Contributor

jmcardon commented Sep 8, 2018

Isnt' this now a module?

@rossabaker
Copy link
Member Author

It is a module. It does not support streaming. aalto-xml could, in a way similar to jawn.

@rossabaker
Copy link
Member Author

Nobody is clamoring for Aalto, and that would be a separate module. XMLEvents is still interesting enough.

@rossabaker rossabaker removed their assignment Apr 5, 2021
@tovbinm
Copy link

tovbinm commented May 18, 2021

FYI, scala-xml dependency is blocking us from upgrading to scala-xml 2.0.0

[error] (app / update) found version conflict(s) in library dependencies; some are suspected to be binary incompatible:
[error] 	* org.scala-lang.modules:scala-xml_2.13:2.0.0 (early-semver) is selected over 1.3.0
[error] 	    +- org.http4s:http4s-scala-xml_2.13:0.21.23           (depends on 1.3.0)

@rossabaker
Copy link
Member Author

scala-xml-2.0 is a breaking change, so we can't really adopt that in 0.21. We are targeting that release in 0.22, which will be released ASAP.

If you can't upgrade http4s right now, you can try overriding that semver warning (it probably works?) or just copy the XML module, which isn't that large.

@tovbinm
Copy link

tovbinm commented May 19, 2021

Thank you. We can wait for the next release.

rossabaker referenced this issue in http4s/http4s-servlet Apr 3, 2022
This makes XML literals as HTML a Bad Idea, so they are ported to
Twirl in the example.

Related to http4s/http4s#153.
rossabaker referenced this issue in http4s/http4s-scala-xml-1 Apr 19, 2022
This makes XML literals as HTML a Bad Idea, so they are ported to
Twirl in the example.

Related to http4s/http4s#153.
@armanbilge armanbilge transferred this issue from http4s/http4s May 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request module:scala-xml
Projects
None yet
Development

No branches or pull requests

4 participants