Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatically turn on relevant organs #757

Open
danqaurooni opened this issue Oct 1, 2024 · 4 comments
Open

Automatically turn on relevant organs #757

danqaurooni opened this issue Oct 1, 2024 · 4 comments
Labels
app: ccf-eui Exploration User Interface full application feature request Feature request for the product team

Comments

@danqaurooni
Copy link

When the custom EUI loads up for an organ, the expected behavior is for the appropriate organ to be "on" and irrelevant organs to be "off". But this doesn't happen and it is confusing to users. For example, if I send the link below to a lung set to someone, the lung is not automatically turned on: https://hubmapconsortium.github.io/hra-registrations/hubmap-lung-pryhuber-2021/

@danqaurooni danqaurooni added bug Something isn't working app: ccf-eui Exploration User Interface full application labels Oct 1, 2024
@LibbyUX
Copy link
Contributor

LibbyUX commented Oct 4, 2024

Thanks for catching this, @danqaurooni. I would also like to see the relevant organ showing when sharing links to specific datasets. I made the organ showing/hiding more explicit in the redesigned interface, however, this cycle focuses on cosmetic alignment of the design system. I am guessing the initial EUI was not designed to do this.

@bherr2,

  • Can you please confirm if this is a bug or a feature request?
  • If this is a feature request, is it feasible to add this feature request to EUI development this cycle EUI Y3 cosmetic update #729 ? Or should I add this to the Design System Expansion milestone for next cycle EUI Y3 feature requests #379 ? I can organize this issue for the product team.

Thanks so much, Dan and Bruce! Happy Friday!

image

@bherr2
Copy link
Member

bherr2 commented Oct 4, 2024

This is a feature request.

@bherr2 bherr2 changed the title Bug Report: Appropriate Organ Does Not Turn On in Custom EUI Automatically turn on relevant organs Oct 4, 2024
@bherr2 bherr2 added feature request Feature request for the product team and removed bug Something isn't working labels Oct 4, 2024
@bherr2
Copy link
Member

bherr2 commented Oct 4, 2024

And it's not as straightforward as one would think. However, the new EUI does have a "selected-organs" attribute where you can set what organs to show on start-up manually.

@bherr2
Copy link
Member

bherr2 commented Oct 4, 2024

It should go to next cycle. @danqaurooni I can show you how to modify the custom EUIs on hra-registrations to set them manually in the meantime.

@LibbyUX LibbyUX added this to the Ideation: DS Expansion milestone Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app: ccf-eui Exploration User Interface full application feature request Feature request for the product team
Projects
None yet
Development

No branches or pull requests

3 participants