NickAkhmetov/CAT-925 ensure visualizations for support image pyramid datasets use parent dataset UUID for notebooks #3570
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adjusts the logic for the "download jupyter notebook" button so that it uses the parent UUID instead of the support dataset's UUID.
Design Documentation/Original Tickets
https://hms-dbmi.atlassian.net/browse/CAT-925
Testing
Manually tested with
/browse/dataset/8690897fced9931da34d66d669c1d698
- was able to successfully download notebook with parent HBM ID as its name.Regression tested with
/browse/dataset/3d14dcc3d7c3e0cd339c9366e34b37c7
to confirm it was still working as expected with non-Support datasets.Screenshots/Video
Downloads kicked off from the pages listed above:
Checklist
CHANGELOG-your-feature-name-here.md
is present in the root directory, describing the change(s) in full sentences.Additional Notes
This endpoint is probably in need of some revisions. It appears to be left over from a previous implementation of workspaces - i.e. there's some workspaces-related language included which might not be relevant anymore, since I believe those notebooks are now fetched from the templates API. We will also likely need to revisit this for EPICs, once we have visualizations ready for them.
I also noticed that the version of vitessce in the created notebook was
3.2.8
, which matches the - we may want to bump the version thatportal-vis
depends on sometime soon to make sure we don't fall behind the functionalities provided upstream.