Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow setting max-weight-norm optimizer parameter #112

Open
jimypbr opened this issue Jun 22, 2022 · 0 comments
Open

Allow setting max-weight-norm optimizer parameter #112

jimypbr opened this issue Jun 22, 2022 · 0 comments
Labels
enhancement New feature or request

Comments

@jimypbr
Copy link
Contributor

jimypbr commented Jun 22, 2022

[From AlexC in GC]
The reference implementation uses a value of 10 for this parameter. However the implementation in GC-Optimum passes None, with no possibility for the user to set this parameter

  • create training command line option --max-weight-norm it can default to None for backwards compatibility
  • in IPUTrainer.create_optimizer pass this argument to LAMB optimizer as part of optimizer_kwargs
@jimypbr jimypbr added the enhancement New feature or request label Jun 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jimypbr