Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding Support for DETA Model #2018

Open
TheMattBin opened this issue Sep 8, 2024 · 2 comments · May be fixed by #2025
Open

Adding Support for DETA Model #2018

TheMattBin opened this issue Sep 8, 2024 · 2 comments · May be fixed by #2025
Labels
onnx Related to the ONNX export

Comments

@TheMattBin
Copy link

Feature request

Adding support for DETA model

Motivation

Currently quite few vision models are supported in optimum, but no DETA, wanna test and compare with others in practical usage.

Your contribution

I can try to submit a PR, just need a bit guide here for vision model for onnx.
@IlyasMoutawwakil
Copy link
Member

Hi ! would love to review a PR 🤗, if you need guidance there's this very cool PR by @xenova that adds support for many vision models #2001.

@TheMattBin
Copy link
Author

Thanks for the reply! I tried my script for testing before submit the PR. However, I encountered an issue like below:

Traceback (most recent call last):
  File "/usr/local/lib/python3.10/dist-packages/torch/nn/modules/module.py", line 1543, in _slow_forward
    result = self.forward(*input, **kwargs)
  File "/usr/local/lib/python3.10/dist-packages/transformers/models/deprecated/deta/modeling_deta.py", line 1750, in forward
    pre_nms_inds.append(torch.topk(prop_logits_b.sigmoid() * lvl_mask, pre_nms_topk)[1])
RuntimeError: selected index k out of range

I'm not sure if this relates to DETA model with transformers. Do you have any ideas on this? Thanks!

@TheMattBin TheMattBin linked a pull request Sep 15, 2024 that will close this issue
Draft
3 tasks
@dacorvo dacorvo added the onnx Related to the ONNX export label Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
onnx Related to the ONNX export
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add ONNX export support for DETA model TheMattBin/optimum
3 participants
@dacorvo @IlyasMoutawwakil @TheMattBin