Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check GIL, rather than Python version #124

Merged
merged 1 commit into from
Jul 7, 2024

Conversation

radarhere
Copy link

Suggestion for python-pillow#8200

At the moment, 3.13-dev installs 3.13.0b2+, and 3.13 installs 3.13.0b2.

In a few months, 3.13-dev will become the same as 3.13. So it seems to me we can just remove the '-dev' suffix now and get it over with.

@hugovk
Copy link
Owner

hugovk commented Jul 6, 2024

Hmm, I think for the time being it might be better to test a nightly build rather than the last tagged one, because things are still being fixed quite regularly upstream for free-threaded and it will be good to help catch things earlier.

There's also some issue with deadsnakes right now, 3.13 is b2 from 8th June instead of b3 from 27th June, 3.13-dev is from 27th June instead of a recent nightly.

I've reported these:

@radarhere radarhere changed the title Use 3.13, rather than than 3.13-dev Check GIL, rather than Python version Jul 7, 2024
@radarhere
Copy link
Author

Ok, I've removed that switch. What about the part that is left - checking GIL variables, rather than the Python version?

@hugovk
Copy link
Owner

hugovk commented Jul 7, 2024

Thanks, this is better, as we may switch to actions/setup-python when they add support, and add 3.14+ later.

@hugovk hugovk merged commit 77e752f into hugovk:ci-free-threading Jul 7, 2024
48 of 49 checks passed
@radarhere radarhere deleted the ci-free-threading branch July 7, 2024 23:19
@radarhere
Copy link
Author

Hmm, I think for the time being it might be better to test a nightly build rather than the last tagged one, because things are still being fixed quite regularly upstream for free-threaded and it will be good to help catch things earlier.

We're now at rc2, so I expect things to be pretty stable at this point. Is it time to switch to 3.13?

@hugovk
Copy link
Owner

hugovk commented Sep 11, 2024

Things should be very stable, and there won't be many non-docs changes made to the 3.13 branch before 3.13.0.

But if something does get in, which subsequently breaks things for us, it will be much better to catch it before the big 3.13.0, and get it fixed before then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants