Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send CORS headers #80

Closed
roborourke opened this issue May 9, 2019 · 1 comment
Closed

Send CORS headers #80

roborourke opened this issue May 9, 2019 · 1 comment

Comments

@roborourke
Copy link
Contributor

There will likely be an extra step to whitelist the headers in Cloudfront but we should send an Access-Control-Allow-Origin header with the requesting domain as the value by default or read in from environment variables / config file.

Right now there are issues where images loaded via JavaScript won't work properly if the tachyon service runs on a separate domain.

@joehoyle
Copy link
Member

joehoyle commented Sep 4, 2023

In #162 we're removing the infrastructure (cloudformation template) and this is then up to the lambda configuration as to if someone wants to enabled it or not

@joehoyle joehoyle closed this as not planned Won't fix, can't repro, duplicate, stale Sep 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants