Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide Network Error #13

Open
ItzNotABug opened this issue Apr 8, 2017 · 4 comments
Open

Hide Network Error #13

ItzNotABug opened this issue Apr 8, 2017 · 4 comments

Comments

@ItzNotABug
Copy link

ItzNotABug commented Apr 8, 2017

Currently the Library shows a Dialog Pop-Up when there is No Internet Connection but instead there should be No Pop-Up at all if there is no Network Connection...

Most of the User's won't even bother to Refresh, so this can be a good feature where the App will only show Pop-Up ads when there is network available...

A method like -
showErrorDialog(false);
would be Good :)

@hummatli
Copy link
Owner

hummatli commented Apr 8, 2017

Hi.
Library caches list at first time and shows it wether there is internet connection or not.

If there is not cached data it shows refresh button. Therefore I thing there is not any need for additional error dialog. :)

@ItzNotABug
Copy link
Author

ItzNotABug commented Apr 8, 2017

Seems like you misunderstood :P
I didn't say to add an Additional error Dialog, I meant that if there is no Cache data or No Network then the Popup with the Refresh button should not show...
Instead it should try to Load it the next time there is a network...
Or try in Background (Async Task) :)

@hummatli
Copy link
Owner

hummatli commented Apr 8, 2017

Hmm. Interesting. I will thing about it.

Thanks for your idea. 👍

@ItzNotABug
Copy link
Author

ItzNotABug commented Apr 8, 2017

You're Welcome :)
Do Update it Regularly :P

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants