Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overrides certificate validation without large warning #14

Open
waldiTM opened this issue May 6, 2015 · 2 comments
Open

Overrides certificate validation without large warning #14

waldiTM opened this issue May 6, 2015 · 2 comments

Comments

@waldiTM
Copy link

waldiTM commented May 6, 2015

hiera-ldap monkey-patches Net::LDAP to disable SSL certificate validation for every connection made, even if done by other code in the same instance. This allows MitM attacks on every connection made. This problem is categorized as CWE-295.

@nibalizer
Copy link
Contributor

As I recall we had to do this because puppet itself was monkey patching Net::LDAP so we had to 'unmonkey' patch it. I also think there was something mumble mumble ruby versions. @petems you want to try using the plugin without the ssl patching and see how it goes today? or @nightfly19 ? I no longer use this software so I'm not the best candidate for driving its development.

@petems
Copy link
Contributor

petems commented May 15, 2015

I'll have a quick go, I'm not able to access a real LDAP instance easily (was at customer site at the time) but I think I should be able to test this with ladle.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants