Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Time HH:MM:SS completely missing from the "Time" column #11

Open
manuelbua opened this issue Feb 4, 2020 · 4 comments
Open

Time HH:MM:SS completely missing from the "Time" column #11

manuelbua opened this issue Feb 4, 2020 · 4 comments

Comments

@manuelbua
Copy link

I'm not sure this being it this way before me moving to macOS, but i now noticed the "Time" column is missing the time itself, only the date is present:

Screenshot 2020-02-04 at 22 07 42

@manuelbua manuelbua changed the title Time completely missing in the "Time" column Time HH:MM:SS completely missing in the "Time" column Feb 4, 2020
@manuelbua manuelbua changed the title Time HH:MM:SS completely missing in the "Time" column Time HH:MM:SS completely missing from the "Time" column Feb 4, 2020
@manuelbua
Copy link
Author

To add more information, i just found out that it seems related to the Burp Dark Theme, when switching to Nimbus for example, this doesn't happen:

Screenshot 2020-02-08 at 18 22 04

@hvqzao
Copy link
Owner

hvqzao commented Feb 9, 2020

I was able to reproduce the issue on dark theme. At the moment I don't really know how to approach this. Behavior of CellRenderer for Darcula theme is different than for remaining themes which means it either is Burp or Darcula itself is doing some strange things under the hood. I don't have much time to investigate it currently. I don't use dark theme so it has little to none priority to me. I highly encourage you to play with the plugin code and submit pull request to me once you will solve it!

@jemjensen
Copy link

Unfortunately, this is back in Burp 2020.11.2 and 2020.11.3 with the new appearance system rollout. It now happens in both the Light and Dark themes.

@jemjensen
Copy link

I think I just checked in a fix for this Time bug, a Dark mode bug (since the name is no longer "darkula" the old code was never triggering to change colors), and a javadoc build issue that was gumming up the builds. It should be in the "dark-mode-fixes" branch if I did it right. Admittedly, I'm not well-versed in git tho so if I need to do something else to get it checked in so I can initiate the pull request let me know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants