Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

should join() eventually be replaced with lattice_join()? #776

Closed
zzlk opened this issue Jun 15, 2023 · 4 comments
Closed

should join() eventually be replaced with lattice_join()? #776

zzlk opened this issue Jun 15, 2023 · 4 comments
Assignees
@MingweiSamuel
Labels
hydroflow syntax Hydroflow's custom surface syntax lattices/properties P2 Medium priority question Further information is requested
Milestone
0.4 release

Comments

@zzlk
Copy link
Contributor

zzlk commented Jun 15, 2023

lattice_join currently requires you to specify lhs/rhs type. We could make lattice_join without lhs/rhs type specifiers default to some ssiv-like type and then remove join(), so all joins would be lattices in hydroflow.

This is related to the long running question of what semantics should join() have, sets or multisets?
@jhellerstein jhellerstein added this to the 0.3 release milestone Jun 20, 2023
@MingweiSamuel MingweiSamuel added question Further information is requested hydroflow syntax Hydroflow's custom surface syntax lattices/properties labels Jun 20, 2023
@zzlk
Copy link
Contributor Author

zzlk commented Jun 22, 2023

join is now multiset join: #774

@zzlk zzlk modified the milestones: 0.3 release, 0.4 release Jun 29, 2023
@jhellerstein
Copy link
Contributor

Join is no longer multiset join: #804

@jhellerstein jhellerstein added the P2 Medium priority label Jul 3, 2023
@jhellerstein
Copy link
Contributor

This should follow naturally after #271, as we sweep through operators and make them properly typed for lattice-valued edges.

@jhellerstein
Copy link
Contributor

Everything is replaced by join and upstream fold-like ops, be they lattices or not. Then fuse them into more efficient variants. We have this going in #861.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MingweiSamuel MingweiSamuel

Labels
hydroflow syntax Hydroflow's custom surface syntax lattices/properties P2 Medium priority question Further information is requested
Projects
None yet
Milestone
0.4 release
Development

No branches or pull requests
3 participants
@jhellerstein @zzlk @MingweiSamuel