Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[hotfix] slack 알림 시 custom 에러의 경우 더 많은 내용을 볼 수 있도록 변경 #173

Merged
merged 1 commit into from
Apr 3, 2022

Conversation

hyejungg
Copy link
Member

@hyejungg hyejungg commented Apr 3, 2022

What is this PR? 🔍

기존에 슬랙 알림 시 custom 에러 발생 시 볼 수 있는 정보를 추가하였습니다.
스크린샷 2022-04-03 오후 6 27 29

이를 추가하여 ec2에 접속하지 않더라도 어떤 요청을 누가 보냈는지 확인합니다.

Key Changes 🔑

  1. Slack에 알림 보낼 때 text 부분에 요청 url, user-agent, ip주소를 확인할 수 있도록 함

@hyejungg hyejungg added bug bug 및 hotfix 수정 fix 잘못된 부분 수정 labels Apr 3, 2022
@hyejungg hyejungg added this to the Code Quality & Refactoring milestone Apr 3, 2022
@hyejungg hyejungg requested a review from youngjinc April 3, 2022 09:30
@hyejungg hyejungg self-assigned this Apr 3, 2022
title: `${err.getCode()} ${err.message}`,
text: `[${req.method}] ${req.url} \`\`\`user-agent: ${req.header(
'user-agent',
)} \nip-adress: ${req.ip}\`\`\``,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

최고..👍🏻

@hyejungg hyejungg linked an issue Apr 3, 2022 that may be closed by this pull request
2 tasks
@hyejungg hyejungg merged commit 353b328 into dev Apr 3, 2022
@hyejungg hyejungg deleted the hotfix-dev-slack branch April 3, 2022 09:43
@hyejungg hyejungg mentioned this pull request Apr 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug bug 및 hotfix 수정 fix 잘못된 부분 수정
Projects
None yet
Development

Successfully merging this pull request may close these issues.

log 개선
2 participants