Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ProgramReader: Incorrect height conversation factor #70

Open
djsiroky opened this issue Nov 18, 2021 · 0 comments
Open

ProgramReader: Incorrect height conversation factor #70

djsiroky opened this issue Nov 18, 2021 · 0 comments

Comments

@djsiroky
Copy link

roomEntry.area = Math.Round(roomEntry.area *= METRIC_FACTOR, 3);
roomEntry.height = Math.Round(roomEntry.height *= METRIC_FACTOR, 3);

Just stumbled across this, I think length (height) and area would have different conversion factors. It appears METRIC_FACTOR is the area conversation between m^2 and ft^2, so you'd want Line 88 to be something like:

roomEntry.height = Math.Round(roomEntry.height *= Math.Sqrt(METRIC_FACTOR), 3);
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant