Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing many types from hyper_old_types::header #76

Open
jplatte opened this issue Nov 27, 2020 · 1 comment
Open

Missing many types from hyper_old_types::header #76

jplatte opened this issue Nov 27, 2020 · 1 comment

Comments

@jplatte
Copy link
Contributor

jplatte commented Nov 27, 2020

I noticed the self_update crate is pulling in a bunch of outdated dependencies through hyper_old_types, but uses only its typed headers for LinkValue and RelationType. I attempted to switch out hyper_old_types for headers, but found that these aren't defined here currently. Have they been removed intentionally or is this crate more of a from-ground rewrite than an extraction of the old typed header from hyper and only needs a PR to add these?

@seanmonstar
Copy link
Member

is this crate more of a from-ground rewrite than an extraction of the old typed header from hyper and only needs a PR to add these?

Mostly this. One goal of this crate was to fix some mistakes with hyper's older typed headers: too many internal details were publicly exposed (structs with all fields public). Ideally this crate could add typed headers in a way where their details aren't exposed, so we can make optimizations or what-have-you without it being a breaking change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants