Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add feature flag such as time,sha1 #86

Open
lexoooooo opened this issue Jun 28, 2021 · 5 comments
Open

Add feature flag such as time,sha1 #86

lexoooooo opened this issue Jun 28, 2021 · 5 comments

Comments

@lexoooooo
Copy link

Users don't always need all the functionality,
we should use feature flags to let them choose, thereby reducing compilation time

@lexoooooo
Copy link
Author

image

Because time crate, the project relies on winapi and libc, severely affecting compilation time

@seanmonstar
Copy link
Member

I have thought that perhaps classes of headers could be optional features. Like auth, conditionals, and the like...

@lexoooooo
Copy link
Author

Can I open a pull request?

@seanmonstar
Copy link
Member

It'd be best to plan what the features would be first, so that way the code part takes less back and forth. Does my comment about features as groups of headers make sense? Do you have thoughts on logical groupings?

@lexoooooo
Copy link
Author

Oh...I don't understand what you mean by groups of headers and logical groupings ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants