Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider renaming HttpConnection::version -> negotiated_version #6

Open
carllerche opened this issue May 28, 2019 · 4 comments
Open

Consider renaming HttpConnection::version -> negotiated_version #6

carllerche opened this issue May 28, 2019 · 4 comments

Comments

@carllerche
Copy link
Contributor

This would make it clearer that the value returned is based on some sort of transport level version negotiation, whether ALPN, HTTP 1.1 upgrade, etc...
@carllerche
Copy link
Contributor Author

My initial gut when seeing HttpConnection::version is that it would return the HTTP version in flight... via some sort of sniffing. So, if an HTTP 1.1 head is sent, the value returned from HttpConnection::version would be 1.1.

@carllerche
Copy link
Contributor Author

cc @seanmonstar @LucioFranco

@seanmonstar
Copy link
Member

Either is fine with me.

@LucioFranco
Copy link
Member

@carllerche I personally perfer version with docs that explain this is the negotiated version but if it makes more sense that way then im fine with it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@carllerche @seanmonstar @LucioFranco