Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make it easier to mutate query parameters in Uri #577

Open
jdisanti opened this issue Nov 16, 2022 · 1 comment
Open

Make it easier to mutate query parameters in Uri #577

jdisanti opened this issue Nov 16, 2022 · 1 comment
Labels
A-uri Area: Uri and parts B-rfc Blocked: request for comments. More discussion would help move this along. S-feature Severity: feature. This adds something new.

Comments

@jdisanti
Copy link

In the AWS SDK, we needed to insert query parameters in an existing Uri for our presigning implementation. There wasn't an easy way to do this in http, so we ended up writing the following QueryWriter:

https://github.com/awslabs/smithy-rs/blob/a0539e20b069a7de021c84521d8f3c7ba098ad6d/aws/rust-runtime/aws-sigv4/src/http_request/query_writer.rs#L9-L73

It would be nice to have built-in utilities for manipulating URI components either in this crate, or in a separate related utility crate.
@seanmonstar seanmonstar added S-feature Severity: feature. This adds something new. B-rfc Blocked: request for comments. More discussion would help move this along. A-uri Area: Uri and parts labels Nov 17, 2022
@seanmonstar
Copy link
Member

It would be nice to make that easier. I know one of the hopes for the uri::Builder was to make it easier to modify various parts, I wonder if that would be the best place to do so? #206

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-uri Area: Uri and parts B-rfc Blocked: request for comments. More discussion would help move this along. S-feature Severity: feature. This adds something new.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@seanmonstar @jdisanti