Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shouldn't use of extern in documentation be removed? #57

Open
finlaydotb opened this issue Jun 14, 2020 · 2 comments
Open

Shouldn't use of extern in documentation be removed? #57

finlaydotb opened this issue Jun 14, 2020 · 2 comments

Comments

@finlaydotb
Copy link

The getting started guide of hyber uses extern crate hyper https://hyper.rs/guides/client/basic/

I was the opinion that extern is no longer necessary and the new/current module system does not require.

and indeed, I confirmed this by removing the extern and the code snippet in the example still works...

Question now is, shouldn't extern be removed from the documentation?

@seanmonstar
Copy link
Member

Yea it could be removed. 🤷‍♂️

@NewbMiao
Copy link
Contributor

NewbMiao commented Feb 3, 2024

Think the extern stuff is for rustdoc testing, eg: rustdoc --edition 2018 --test _stable/server/hello-word.md -L "stable/target/debug/deps".
Check this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants