Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(plugin-htlc-coordinator-besu): use Jest error assert in refund.test #3457

Open
petermetz opened this issue Aug 4, 2024 · 4 comments
Open
Assignees
Labels
Hacktoberfest Hacktoberfest participants are welcome to take a stab at issues marked with this label. P3 Priority 3: Medium Tests Anything related to tests be that automatic or manual, integration or unit, etc.

Comments

@petermetz
Copy link
Member

Description

Refactor the negative test case exception assertions so that they do not use try-catch blocks but instead declare the requirements through Jest's (and jest-extended's) own API.

The parent issue with a much more detailed explanation of what's needed and code examples on how to do it:
Parent Issue: #3455

The test case to work on in the scope of this issue:
extensions/cactus-plugin-htlc-coordinator-besu/src/test/typescript/integration/plugin-htlc-coordinator/refund.test.ts

The way to run the test case:
yarn jest extensions/cactus-plugin-htlc-coordinator-besu/src/test/typescript/integration/plugin-htlc-coordinator/refund.test.ts

Acceptance Criteria

  1. Test passes the same as before
  2. Negative test case assertions have been migrated the way it is explained in the parent issue.
@Deepakchowdavarapu
Copy link

I would like to work on this issue.

@petermetz
Copy link
Member Author

I would like to work on this issue.

@Deepakchowdavarapu You got it! Thank you in advance for the contribution!

@petermetz petermetz added Hacktoberfest Hacktoberfest participants are welcome to take a stab at issues marked with this label. Tests Anything related to tests be that automatic or manual, integration or unit, etc. P3 Priority 3: Medium labels Aug 4, 2024
@Deepakchowdavarapu
Copy link

@petermetz please review my work #3460

@petermetz
Copy link
Member Author

@Deepakchowdavarapu Please see the reviews posted on the pull request! Let me know if you need any help with any of it and I also wanted to let you know about the daily pair programming sessions that we host which are open for everyone on the internet to come in and ask questions about Cacti: https://wiki.hyperledger.org/display/cactus/Daily+Pair+Programming+Calls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Hacktoberfest Hacktoberfest participants are welcome to take a stab at issues marked with this label. P3 Priority 3: Medium Tests Anything related to tests be that automatic or manual, integration or unit, etc.
Projects
Status: No status
Development

No branches or pull requests

2 participants