Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: fix all broken validations in packages folder #3493

Open
ashnashahgrover opened this issue Aug 26, 2024 · 1 comment · May be fixed by #3495
Open

test: fix all broken validations in packages folder #3493

ashnashahgrover opened this issue Aug 26, 2024 · 1 comment · May be fixed by #3495
Labels
bug Something isn't working

Comments

@ashnashahgrover
Copy link
Contributor

Describe the bug

Two tests are failing in the packages folder:

- From packages/cactus-plugin-ledger-connector-xdai/src/test/typescript/integration/deploy-contract-from-json-xdai.test.ts:

  1. test("invoke Web3SigningCredentialType.PrivateKeyHex") and
  2. test("invoke Web3SigningCredentialType.CACTUSKEYCHAINREF")

To Reproduce

Run these tests in run and debug and note the failing tests in the terminal output.

Expected behavior

The failing tests should pass - contingent upon the jest assertions in those tests also passing. If the test description says the specific function called should return an error, it should return an error and not a resolved promise.
@ashnashahgrover ashnashahgrover added the bug Something isn't working label Aug 26, 2024
@ashnashahgrover ashnashahgrover mentioned this issue Aug 26, 2024
Open
@ashnashahgrover
Copy link
Contributor Author

This issue is a dependency of #3483

ashnashahgrover added a commit to ashnashahgrover/cacti that referenced this issue Aug 26, 2024
@ashnashahgrover
test: fix all broken validations in packages folder 
a0621be 
Primary Changes
---------------
1. Fixed broken assertions in deploy-contract-from-json-xdai.test.ts so they assert that “Nonce is too low”
as expected.

Fixes hyperledger#3493

Signed-off-by: ashnashahgrover <[email protected]>
ashnashahgrover added a commit to ashnashahgrover/cacti that referenced this issue Aug 27, 2024
@ashnashahgrover
test: fix all broken validations in packages folder 
772dcf5 
Primary Changes
---------------
1. Fixed broken assertions in deploy-contract-from-json-xdai.test.ts so they assert that “Nonce is too low”
as expected.

Fixes hyperledger#3493

Signed-off-by: ashnashahgrover <[email protected]>
ashnashahgrover added a commit to ashnashahgrover/cacti that referenced this issue Aug 27, 2024
@ashnashahgrover
test: fix all broken validations in packages folder 
28ccb3d 
Primary Changes
---------------
1. Fixed broken assertions in deploy-contract-from-json-xdai.test.ts so they assert that “Nonce is too low”
as expected.

Fixes hyperledger#3493

Signed-off-by: ashnashahgrover <[email protected]>
@ashnashahgrover ashnashahgrover linked a pull request Aug 27, 2024 that will close this issue
Open
5 tasks
ashnashahgrover added a commit to ashnashahgrover/cacti that referenced this issue Sep 3, 2024
@ashnashahgrover
test: fix all broken validations in packages folder 
a65480d 
Primary Changes
---------------
1. Fixed broken assertions in deploy-contract-from-json-xdai.test.ts so they assert that “Nonce is too low”
as expected.

Fixes hyperledger#3493

Signed-off-by: ashnashahgrover <[email protected]>
ashnashahgrover added a commit to ashnashahgrover/cacti that referenced this issue Sep 3, 2024
@ashnashahgrover
test: fix all broken validations in packages folder 
4d717a0 
Primary Changes
---------------
1. Fixed broken assertions in deploy-contract-from-json-xdai.test.ts so they assert that “Nonce is too low”
as expected.

Fixes hyperledger#3493

Signed-off-by: ashnashahgrover <[email protected]>
ashnashahgrover added a commit to ashnashahgrover/cacti that referenced this issue Sep 3, 2024
@ashnashahgrover
test: fix all broken validations in packages folder 
0053b3e 
Primary Changes
---------------
1. Fixed broken assertions in deploy-contract-from-json-xdai.test.ts so they assert that
“Nonce is too low” as expected.

Fixes hyperledger#3493

Signed-off-by: ashnashahgrover <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

test: fix all broken validations in packages folder ashnashahgrover/cacti
2 participants
@ashnashahgrover and others