fix(security): vulnerabilities found in corda-4-8-all-in-one Fixes #2064 #2437
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adrianbatuto
changed the title
adrianbatuto
force-pushed
the
vulnerability-scan
branch
from
efc4b02
to
085852f
Compare
adrianbatuto
requested review from
petermetz,
takeutak,
izuru0,
jagpreetsinghsasan,
VRamakrishna and
sandeepnRES
as code owners
adrianbatuto
force-pushed
the
vulnerability-scan
branch
from
085852f
to
2ae8f00
Compare
adrianbatuto
force-pushed
the
vulnerability-scan
branch
from
2ae8f00
to
45661f5
Compare
Signed-off-by: adrianbatuto <[email protected]>
adrianbatuto
force-pushed
the
vulnerability-scan
branch
from
45661f5
to
b3368ce
Compare
Signed-off-by: adrianbatuto <[email protected]>
petermetz
requested changes
Jun 14, 2023
There was a problem hiding this comment.
@adrianbatuto Thank you! Please do the following and then pass it back for re-review:
- Confirm that the new image is functioning well via locally executed manual testing:
1.1. build the image locally,
1.2. modify one of the test cases to use said local image
1.3. run the test case against the locally built image
1.4. post here the steps you took to do all the above, the exact path to the test case and the complete logs the test case produced while using the image - Explain how did you verify that the vulnerabilities are fixed by the change you just made (e.g. did you re-run the scan locally and it showed the warnings missing or something?)
- Remove the azure-container-scan.yaml file from the diff, we can add the container scanning in another PR (I think there was another task+PR for it already too)
|
@adrianbatuto any updates on this? |
Hi @jagpreetsinghsasan , currently looking into this and following Peter's instructions. |
adrianbatuto
force-pushed
the
vulnerability-scan
branch
3 times, most recently
from
0d89609
to
6b0aaed
Compare
…cacti into vulnerability-scan
adrianbatuto
force-pushed
the
vulnerability-scan
branch
from
6b0aaed
to
0bb0b69
Compare
|
Closing this for now, let's re-open it once it's ready to be reviewed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.