test(ethereum): refactor jest test negative test cases #3476
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashnashahgrover
requested review from
petermetz,
takeutak,
izuru0,
jagpreetsinghsasan,
VRamakrishna,
sandeepnRES and
outSH
as code owners
petermetz
requested changes
Aug 12, 2024
...src/test/typescript/integration/geth-contract-deploy-and-invoke-using-json-object-v1.test.ts
Outdated
Show resolved
Hide resolved
...src/test/typescript/integration/geth-contract-deploy-and-invoke-using-json-object-v1.test.ts
Outdated
Show resolved
Hide resolved
...um/src/test/typescript/integration/geth-contract-deploy-and-invoke-using-keychain-v1.test.ts
Outdated
Show resolved
Hide resolved
...um/src/test/typescript/integration/geth-contract-deploy-and-invoke-using-keychain-v1.test.ts
Outdated
Show resolved
Hide resolved
...ledger-connector-ethereum/src/test/typescript/integration/geth-invoke-web3-method-v1.test.ts
Outdated
Show resolved
Hide resolved
RafaelAPB
approved these changes
Aug 13, 2024
ashnashahgrover
force-pushed
the
ashnashahgrover/issue3475
branch
2 times, most recently
from
1280003
to
f01487a
Compare
ashnashahgrover
force-pushed
the
ashnashahgrover/issue3475
branch
from
f01487a
to
032e7ae
Compare
petermetz
approved these changes
Aug 27, 2024
|
@ashnashahgrover Please fix the lint check and then we are good to merge |
This is done @petermetz |
petermetz
requested changes
Sep 3, 2024
There was a problem hiding this comment.
@ashnashahgrover Looks like it is still failing on the CI unfortunately. Another thing: Please rebase and squash the commits instead of putting merge commits on the PR (right now it has 2 commits, it should only have the 1 which is the actual change)
Primary Changes --------------- 1. Refactored negative test case exception assertions for cactus-plugin-ledger-connector-ethereum. Removed try-catch blocks, replaced with declarations through jest-extended's own API. 2. Made comments on specific tests where the tests should fail but are actually passing and thus cannot be refactored before being investigated further. Fixes hyperledger-cacti#3475 Signed-off-by: ashnashahgrover <[email protected]>
ashnashahgrover
force-pushed
the
ashnashahgrover/issue3475
branch
from
76b2e41
to
c034070
Compare
|
Closing this due to inactivity. Happy to reopen it anytime in the future as needed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit to be reviewed
test(ethereum): refactor jest test negative test cases
Fixes #3475
Pull Request Requirements
upstream/mainbranch and squashed into single commit to help maintainers review it more efficient and to avoid spaghetti git commit graphs that obfuscate which commit did exactly what change, when and, why.-sflag when usinggit commitcommand. You may refer to this link for more information.Character Limit
A Must Read for Beginners
For rebasing and squashing, here's a must read guide for beginners.