Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Licenses need fixed. #4945

Closed
ryjones opened this issue Aug 7, 2024 · 2 comments · Fixed by #4946
Closed

Licenses need fixed. #4945

ryjones opened this issue Aug 7, 2024 · 2 comments · Fixed by #4946
Assignees
@yacovm @denyeart @ale-linux
Labels
bug

Comments

@ryjones
Copy link
Member

ryjones commented Aug 7, 2024

Description

The latest license scan shows several files out of compliance.

Steps to reproduce

Finding #1
Priority: High
These files are under the MPL-2.0 license, a weak copyleft license, which may be incompatible with your project license. I recommend that you remove these files, and if they can't be removed you must be sure that they are not combined or integrated with any other project code in your repo.

fabric-2024-07-24.zip/fabric/vendor/github.com/hashicorp/hcl/LICENSE
@ryjones ryjones added the bug label Aug 7, 2024
This was referenced Aug 7, 2024
Open
Open
@ryjones
Copy link
Member Author

ryjones commented Aug 7, 2024

see also

see also

@yacovm
Copy link
Contributor

yacovm commented Aug 7, 2024

Viper uses hcl:

vendor/github.com/spf13/viper/viper.go:	"github.com/hashicorp/hcl"
vendor/github.com/spf13/viper/viper.go:	"github.com/hashicorp/hcl/hcl/printer"

But recently they moved away from it.

All that is needed is to upgrade the viper version, I guess.

denyeart added a commit to denyeart/fabric that referenced this issue Aug 8, 2024
@denyeart
Bump viper to v1.20.0-alpha.6
b5773d3 
Although we don't usually immediately go to an alpha release of a dependency,
in this case it is compelling to do so since viper v1.20 has removed
dependency on github.com/hashicorp/hcl which had a less
friendly MPL-2.0 license.

Resolves hyperledger#4945

Signed-off-by: David Enyeart <[email protected]>
@denyeart denyeart mentioned this issue Aug 8, 2024
Merged
@yacovm yacovm closed this as completed in 5c0f33c Aug 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yacovm yacovm

@denyeart denyeart

@ale-linux ale-linux

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Bump viper to v1.20.0-alpha.6 denyeart/fabric
4 participants
@ryjones @yacovm @denyeart @ale-linux