Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve GPU support in examples #1146

Draft
wants to merge 11 commits into
base: master
Choose a base branch
from
Draft

Improve GPU support in examples #1146

wants to merge 11 commits into from

Conversation

victorapm
Copy link
Contributor

@victorapm victorapm commented Sep 29, 2024

  • Add HIP support to examples
  • Improve examples Makefile (refactoring and GPU support is recognized automatically without the need of passing an extra flag such as use_cuda=1)
  • Add custom_ prefix to memory function wrappers (malloc, calloc, and free) to avoid confusion with functions from stdlib.h
  • Rename examples ex[1-9] to ex0[1-9] for better folder organization
  • Fix compilation warnings
  • Add README.md file with a high-level description about the examples and notes about GPU usage

Closes #1129

@victorapm victorapm marked this pull request as draft September 30, 2024 18:53
@victorapm
Copy link
Contributor Author

victorapm commented Sep 30, 2024

Given #268 (comment),

Let me continue working on this. Any feedback is welcomed, e.g., what do you think about the other changes here?

The main reason for including Makefile.config is to get access to how hypre was compiled and info about its dependencies. How could we do that with a plain Makefile that works out of the batch (e.g., without having to pass options like use_cuda=1)? I guess having pkg-config support is a good answer to this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Building with cuda gives an error in HYPRE_handle.c.o
1 participant