Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exploration: Rework of our internal model - specifically optical elements #227

Closed
Atraxus opened this issue Nov 28, 2023 · 1 comment
Closed
Assignees
Labels
A-core Area: The core library (rayx-core) C-refactor Category: Improve code quality question Further information is requested

Comments

@Atraxus
Copy link
Collaborator

Atraxus commented Nov 28, 2023

  • We need a first iteration of an API for design parts of the optical elements and light sources
  • Rayx-design as library for applications that need design parameters
@Atraxus Atraxus added question Further information is requested C-refactor Category: Improve code quality A-core Area: The core library (rayx-core) labels Nov 28, 2023
@memoryleak47 memoryleak47 mentioned this issue Dec 19, 2023
1 task
@memoryleak47
Copy link
Collaborator

memoryleak47 commented Dec 19, 2023

As explained in #188, this is a blocker for the new RML format.
Before implementing a new parser, we need to have a DesignElement format - in other words something like "Element" but with all the design parameters still in there.

We'd need a DesignElement later, eg. for the GUI - the user doesn't want to interact with our Shader-internal model, but probably prefers to access it through design parameters.

As we don't require DesignElement to be accessible within the shader, we can use unrestricted c++ to implement it.
In the design-element-variadic branch, I implemented a very templatey version for the DesignElement approach - featuring an automatic parser generator for toml.
We decided against merging it, due to its complexity - which ultimately did not seem worth it.

@Atraxus Atraxus closed this as completed Jun 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-core Area: The core library (rayx-core) C-refactor Category: Improve code quality question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants