Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose full API of lightsources in design model, not in internal model #329

Open
ichinii opened this issue Sep 23, 2024 · 0 comments
Open
Assignees
Labels
A-core Area: The core library (rayx-core) C-enhancement Category: Adding a new feature question Further information is requested

Comments

@ichinii
Copy link
Collaborator

ichinii commented Sep 23, 2024

current status

DesignSource exposes common API among different lightsources. Compiling a DesignSource into one of the lightsources releaves new API specific for that lightsource.

motivation

  • API in different places is confusing
  • clear differentiation between design model and internal model
  • internal model should be minimal and compact
  • conceptually internal model would not be mutated by users at all. thus, internal model data can be constant
  • internal model should be designed to meet favors of accelerators

request

remove everything that should be design API from the internal model to the design model

@ichinii ichinii added C-enhancement Category: Adding a new feature question Further information is requested A-core Area: The core library (rayx-core) labels Sep 23, 2024
@ichinii ichinii assigned Atraxus and ichinii and unassigned Atraxus Sep 23, 2024
@ichinii ichinii changed the title For Lightsources, expose (currently unused) parameters to design model Expose full API of lightsources Sep 23, 2024
@ichinii ichinii changed the title Expose full API of lightsources Expose full API of lightsources in design model, not in internal model Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-core Area: The core library (rayx-core) C-enhancement Category: Adding a new feature question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants