add enum EventType #337
Open
add enum EventType #337
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
ichinii
force-pushed
the
enum_eventtype
branch
from
8a134dd to
abe1411
Compare
Atraxus
requested changes
Oct 14, 2024
in order to override, we want to ensure nothing breaks. electric fields are considered incorrect, thus test precision is adjusted.
ichinii
force-pushed
the
enum_eventtype
branch
from
abe1411 to
d1ac3b9
Compare
|
this PR is not relevant for the next release |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
for event type, use an enum instead of doubles