Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Issue] Render issue with Sync #2

Closed
gatoborrachon opened this issue Dec 15, 2020 · 12 comments · May be fixed by iChun/Sync#236
Closed

[Issue] Render issue with Sync #2

gatoborrachon opened this issue Dec 15, 2020 · 12 comments · May be fixed by iChun/Sync#236

Comments

@gatoborrachon
Copy link

Describe the bug
The chambers from Sync mod are badly rendered, the glass is the only thing rendered.

To Reproduce
Steps to reproduce the behavior:

  1. Install Sync and Entity Culling
  2. Place any Sync chamber
  3. See error

Expected behavior
you will see how it is badly rendered

Screenshots
Without EntityCulling
2020-12-15_13 21 10

With Entity Culling 2.0.0
2020-12-15_14 27 01

Versions
Entity Culling: 2.0.0
Forge: 14.23.5.2854
Minecraft: 1.12.2
Sync: 7.1.0

Other
Latest log (upload as a file):
2020-12-15-4.log

Singleplayer
Other mods (Sync):

@Meldexun
Copy link
Owner

Meldexun commented Dec 15, 2020

I'm unable to reproduce the issue with only entity culling and sync. Please check what mods are needed to reproduce the issue.
nvm, I will look into it.

@gatoborrachon
Copy link
Author

you can see the issue? or you mean that you will look into the log and see which mods i have? i have like 200+ so if you want i can do a binary search

@Meldexun
Copy link
Owner

I can reproduce the issue with only entity culling and sync

@gatoborrachon
Copy link
Author

ok

@Meldexun
Copy link
Owner

It's an issue on their end. I will open an issue on their side but I don't think there will be an update.

@gatoborrachon
Copy link
Author

yeah, Ichun will never fix it, anyways thanks, i will keep using 1.0.3

@gatoborrachon
Copy link
Author

gatoborrachon commented Dec 15, 2020

mmm, is there a way to blacklist tile entities right? let me try it

@Meldexun
Copy link
Owner

Entity Culling changes the way minecraft iterates over the render chunks and checks wether or not to render an entity/tile entity. That means there can't be a blacklist because the vanilla code is never called.
(the blacklist in the config is there to blacklist entities from the skipHiddenTileEntityRendering feature)

@gatoborrachon
Copy link
Author

oh, ok.
well, the last thing i can say, you know how to fix this inside Sync? i don't know much about coding, but at least i can build a dev environment with the mod, the issue here is that i have no idea what to change, and how do it, but you know which changes do? i know everything has a license, but i will just it for personal use

@Meldexun
Copy link
Owner

Wanted to tell you about that right now.
It should be enough to change 1 file:
Sync/src/main/java/me/ichun/mods/sync/client/render/TileRendererDualVertical.java

In there just replace every BlockDualVertical.renderPass with MinecraftForgeClient.getRenderPass()
And add import net.minecraftforge.client.MinecraftForgeClient; to the imports at the top of the file.

@gatoborrachon
Copy link
Author

many many thanks, really, i will try it right now and report it to you.

@gatoborrachon
Copy link
Author

sorry for taking much, yeah it worked, i'm going to open a pull request, just for formality

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants