New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Video block has an aria-label on the div #46

Open

troyrutter opened this issue Nov 22, 2024 · 1 comment

troyrutter commented Nov 22, 2024

Apparently div's aren't supposed to have aria labels. Giving the following accessibility issue in site improve:

An ARIA attribute has been specified that is either not supported or is prohibited, on this type of element.

Screenshot 2024-11-22 at 3 29 27 PM

Author

troyrutter commented Dec 30, 2024 •

edited

Loading

according to https://www.davidmacd.com/blog/does-aria-label-override-static-text.html#:~:text=By%20design%2C%20aria%2Dlabel%20or,ignored%20by%20VoiceOver%20on%20iOS).

DIVs should only have aria labels if they have role=navigation, search, main, img

Based on this and other research, the aria-label on the video embed div should be removed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment