Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I18N issues #864

Open
hbruch opened this issue Oct 7, 2022 · 1 comment
Open

I18N issues #864

hbruch opened this issue Oct 7, 2022 · 1 comment

Comments

@hbruch
Copy link
Contributor

hbruch commented Oct 7, 2022

Though some work regarding I18N already has been done, and I managed to create and apply a (yet incomplete) German translations file, there are still some places in the code and config, where I18N is still to be done (as already mentioned by @landonreed in #695).

While including translated messages for currently untranslated strings in components is work but mostly straight forward, I'm not quite sure regarding gtfs.yml. I currently think the text and helpContent should rather be messageIds and the actual text moved to the translation files (english.yml and others).

Another option would be to create localised gtfs.yml files, which would dulicate a lot of configuration data and might lead to inconsistencies in the long term.

Do you have a preference or better ideas and would such a change be accepted?

@miles-grant-ibigroup
Copy link
Contributor

Thanks so much for all this work! The approach of moving the gtfs.yml message IDs sounds reasonable to me. We welcome all new PRs and we'd love to support more languages.

Thanks again!

@hbruch hbruch mentioned this issue Oct 17, 2022
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants