From ede3a83d758b00d4a1b7cfcc2ae7087021ea893d Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Kriszti=C3=A1n=20Sz=C5=B1cs?= Date: Thu, 11 Apr 2024 19:32:58 +0200 Subject: [PATCH] test(backends): remove now unused `supports_floating_modulus` backend flag (#8939) Test case configuration now happens through pytest markers. depends on #8937 --------- Co-authored-by: Gil Forsyth --- docs/contribute/05_reference.qmd | 1 - ibis/backends/bigquery/tests/conftest.py | 1 - ibis/backends/clickhouse/tests/conftest.py | 1 - ibis/backends/exasol/tests/conftest.py | 1 - ibis/backends/tests/base.py | 2 -- 5 files changed, 6 deletions(-) diff --git a/docs/contribute/05_reference.qmd b/docs/contribute/05_reference.qmd index ae5148f6c292..b90a89a633ed 100644 --- a/docs/contribute/05_reference.qmd +++ b/docs/contribute/05_reference.qmd @@ -18,7 +18,6 @@ from ibis.backends.tests.base import BackendTest class TestConf(BackendTest): """Backend-specific class with information for testing.""" - supports_floating_modulus = False returned_timestamp_unit = "us" supports_structs = True supports_json = True diff --git a/ibis/backends/bigquery/tests/conftest.py b/ibis/backends/bigquery/tests/conftest.py index 23b988d92483..6ec942e92a5a 100644 --- a/ibis/backends/bigquery/tests/conftest.py +++ b/ibis/backends/bigquery/tests/conftest.py @@ -21,7 +21,6 @@ class TestConf(BackendTest): """Backend-specific class with information for testing.""" - supports_floating_modulus = False returned_timestamp_unit = "us" supports_structs = True supports_json = True diff --git a/ibis/backends/clickhouse/tests/conftest.py b/ibis/backends/clickhouse/tests/conftest.py index d15b6e122267..b050527fc935 100644 --- a/ibis/backends/clickhouse/tests/conftest.py +++ b/ibis/backends/clickhouse/tests/conftest.py @@ -26,7 +26,6 @@ class TestConf(ServiceBackendTest): check_dtype = False returned_timestamp_unit = "s" supported_to_timestamp_units = {"s"} - supports_floating_modulus = False supports_json = False force_sort = True rounding_method = "half_to_even" diff --git a/ibis/backends/exasol/tests/conftest.py b/ibis/backends/exasol/tests/conftest.py index 04dea9610ce9..f08bd369878f 100644 --- a/ibis/backends/exasol/tests/conftest.py +++ b/ibis/backends/exasol/tests/conftest.py @@ -29,7 +29,6 @@ class TestConf(ServiceBackendTest): supports_arrays = False returned_timestamp_unit = "us" supported_to_timestamp_units = {"s", "ms", "us"} - supports_floating_modulus = True native_bool = True supports_structs = False supports_json = False diff --git a/ibis/backends/tests/base.py b/ibis/backends/tests/base.py index d4336be6dd7f..92702d37f232 100644 --- a/ibis/backends/tests/base.py +++ b/ibis/backends/tests/base.py @@ -38,8 +38,6 @@ class BackendTest(abc.ABC): "Whether backend supports Arrays / Lists" returned_timestamp_unit: str = "us" supported_to_timestamp_units = {"s", "ms", "us"} - supports_floating_modulus: bool = True - "Whether backend supports floating point in modulus operations" native_bool: bool = True "Whether backend has native boolean types" supports_structs: bool = True