Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(polars): use elementwise flatten to flatten nested arrays #10168

Merged
merged 2 commits into from
Sep 23, 2024

Conversation

cpcloud
Copy link
Member

@cpcloud cpcloud commented Sep 19, 2024

Fixes #10135.

@cpcloud cpcloud added this to the 10.0 milestone Sep 19, 2024
@cpcloud cpcloud added bug Incorrect behavior inside of ibis polars The polars backend labels Sep 19, 2024
@cpcloud cpcloud changed the title fix(polars): use double explode -> implode hack to flatten nested arrays fix(polars): use elementwise flatten hack to flatten nested arrays Sep 19, 2024
@cpcloud cpcloud changed the title fix(polars): use elementwise flatten hack to flatten nested arrays fix(polars): use elementwise flatten to flatten nested arrays Sep 19, 2024
@cpcloud cpcloud force-pushed the polars-flatten branch 2 times, most recently from 97c408e to 58fecf7 Compare September 20, 2024 10:46
@cpcloud
Copy link
Member Author

cpcloud commented Sep 20, 2024

I still want to see if I can workaround the null/empty issue here, so moving to draft for now.

@cpcloud cpcloud marked this pull request as draft September 20, 2024 13:30
@cpcloud
Copy link
Member Author

cpcloud commented Sep 23, 2024

I think this is the best we can do for now.

@cpcloud cpcloud marked this pull request as ready for review September 23, 2024 10:11
@github-actions github-actions bot added the tests Issues or PRs related to tests label Sep 23, 2024
@gforsyth gforsyth merged commit f97bb77 into ibis-project:main Sep 23, 2024
76 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Incorrect behavior inside of ibis polars The polars backend tests Issues or PRs related to tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: polars flatten does not work as expected
2 participants