fix(api): use to_pyarrow() instead of execute() when pretty printing scalars
#10186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Right, we have some backends that actually go through pandas to get to pyarrow. |
jcrist
reviewed
Sep 23, 2024
| repr(table.limit(1).string_col) | ||
|
|
||
| # execute doesn't get called | ||
| execute_spy.assert_not_called() |
There was a problem hiding this comment.
Right, we have some backends that actually go through pandas to get to pyarrow.
If things pass otherwise, the fix seems fine to me without this test at all. No need to assert we're not calling execute when reading the formatting code it's clear we go through to_pyarrow.
There was a problem hiding this comment.
The main point of this test was to make it explicit what happens and in this case make us aware of any backends that have coupling between the pandas and pyarrow format converters. I think I'll leave the test, with appropriate xfails, as a form of documentation.
cpcloud
force-pushed
the
pyarrow-pretty
branch
from
05172cd
to
e33615d
Compare
…rrow` check passes
jcrist
approved these changes
Sep 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #10185.